[ISSUE-708] change @Transactional readOnly for select query #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: render false condition for in condition if the compare values is empty
kihwankim
requested review from
pickmoment,
huisam,
cj848 and
shouwn
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 335 335
Lines 3419 3419
Branches 203 203
=======================================
Hits 3146 3146
Misses 213 213
Partials 60 60 ☔ View full report in Codecov by Sentry. |
cj848
approved these changes
May 19, 2024
|
Did you create a PR on the main branch because you think this change should be released as a hotfix? If not, please change the base branch to the develop branch. |
|
@shouwn I changed |
|
@kihwankim Thanks for the change. The branch change caused a conflict, please check it out or create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@Transactionalbut in select query they put readOnly trueModifications
@TransactionalreadOnly option changed(false -> true) for select queryResult
Closes